Re: FindPythonLibs should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: FindPythonLibs should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH

Marcel Loose
On Mon, 2009-09-07 at 22:01 +0200, Alexander Neundorf wrote:

> On Monday 07 September 2009, Marcel Loose wrote:
> > Hi all,
> >
> > In fact the subject line says it all. To be compliant with the naming
> > conventions proposed in the Modules/readme.txt file, FindPythonLibs
> > should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH.
> >
> > To avoid breaking existing software, it would be best to simply just add
> > a definition for PYTHON_INCLUDE_DIR.
>
> please put it in the bug tracker, ideally together with a patch :-)
>
> Alex

It's in the tracker (issue #9508).

Regards,
Marcel Loose


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: FindPythonLibs should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH

Marcel Loose
On Wed, 2009-09-09 at 09:26 +0200, Marcel Loose wrote:

> On Mon, 2009-09-07 at 22:01 +0200, Alexander Neundorf wrote:
> > On Monday 07 September 2009, Marcel Loose wrote:
> > > Hi all,
> > >
> > > In fact the subject line says it all. To be compliant with the naming
> > > conventions proposed in the Modules/readme.txt file, FindPythonLibs
> > > should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH.
> > >
> > > To avoid breaking existing software, it would be best to simply just add
> > > a definition for PYTHON_INCLUDE_DIR.
> >
> > please put it in the bug tracker, ideally together with a patch :-)
> >
> > Alex
>
> It's in the tracker (issue #9508).
>
> Regards,
> Marcel Loose

Along with a patch.

Marcel


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: FindPythonLibs should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH

Mathieu Malaterre
On Wed, Sep 9, 2009 at 10:08 AM, Marcel Loose<[hidden email]> wrote:

> On Wed, 2009-09-09 at 09:26 +0200, Marcel Loose wrote:
>> On Mon, 2009-09-07 at 22:01 +0200, Alexander Neundorf wrote:
>> > On Monday 07 September 2009, Marcel Loose wrote:
>> > > Hi all,
>> > >
>> > > In fact the subject line says it all. To be compliant with the naming
>> > > conventions proposed in the Modules/readme.txt file, FindPythonLibs
>> > > should set PYTHON_INCLUDE_DIR instead of PYTHON_INCLUDE_PATH.
>> > >
>> > > To avoid breaking existing software, it would be best to simply just add
>> > > a definition for PYTHON_INCLUDE_DIR.
>> >
>> > please put it in the bug tracker, ideally together with a patch :-)
>> >
>> > Alex
>>
>> It's in the tracker (issue #9508).
>>
>> Regards,
>> Marcel Loose
>
> Along with a patch.

Please link to http://www.cmake.org/Bug/view.php?id=2257

Thx
--
Mathieu
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake