Does JOB_POOL_[COMPILE|LINK] work with custom_target?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Does JOB_POOL_[COMPILE|LINK] work with custom_target?

Eric Noulard
Hi all,

We have a bunch of custom_target and a subset of them should be run in sequence.
So we tried to define:

set_property(GLOBAL PROPERTY JOB_POOLS exclusive=1)

and then:

set_property(TARGET my_custom_target PROPERTY JOB_POOL_COMPILE exclusive)
set_property(TARGET my_custom_target PROPERTY JOB_POOL_LINK exclusive)


This does not seem to reach build.ninja ?

The new pool is defined but the concerned custom targets are never assigned to the pool?

May custom target be assigned to a ninja pool? 
If so how can we do that?
--
Eric

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: Does JOB_POOL_[COMPILE|LINK] work with custom_target?

Eric Noulard
Hi all, 
No answer whatsoever on this?

Initial contributor of Ninja job pool appears to be Peter Kümmel:
commit 7605e37aabae2678e5696a75e84aced2e84f9037
Author: Peter Kümmel <[hidden email]>
Date:   Sat Nov 23 10:49:36 2013 +0100


I'd like to be able assign some custom targets to a ninja job pool.
If I were to implement the feature would it be acceptable upstream ?

Eric

2017-05-05 16:16 GMT+02:00 Eric Noulard <[hidden email]>:
Hi all,

We have a bunch of custom_target and a subset of them should be run in sequence.
So we tried to define:

set_property(GLOBAL PROPERTY JOB_POOLS exclusive=1)

and then:

set_property(TARGET my_custom_target PROPERTY JOB_POOL_COMPILE exclusive)
set_property(TARGET my_custom_target PROPERTY JOB_POOL_LINK exclusive)


This does not seem to reach build.ninja ?

The new pool is defined but the concerned custom targets are never assigned to the pool?

May custom target be assigned to a ninja pool? 
If so how can we do that?
--
Eric



--
Eric

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: [cmake-developers] Does JOB_POOL_[COMPILE|LINK] work with custom_target?

Ben Boeckel-2
On Mon, May 15, 2017 at 11:46:37 +0200, Eric Noulard wrote:
> No answer whatsoever on this?

I don't think it is supported right now.

> I'd like to be able assign some custom targets to a ninja job pool.
> If I were to implement the feature would it be acceptable upstream ?

I think it'd be fine.

--Ben
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake