CMake 3.12 rc2 to rc3 Regression

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

CMake 3.12 rc2 to rc3 Regression

Michael Jackson
There was a regression between 3.12-rc2 and 3.12-rc3 where we can no longer add files to a target unless it was built in the directory that is currently being cmaked? Hard to explain, I'll let my error message help out:

In CMake 3.12-rc3 and the 3.12 Official Release I get the following:

-- TransformationPhase [ENABLED] 3 Filters
-- Plugin: Defining UCSBUtilities_SOURCE_DIR to /Users/mjackson/DREAM3D-Dev/DREAM3D/ExternalProjects/Plugins/UCSBUtilities
CMake Error at ExternalProjects/SIMPL/Wrapping/Python/Pybind11/cmake/WrappingFunctions.cmake:144 (target_link_libraries):
  Attempt to add link library "UCSBUtilitiesServer" to target "dream3d_py"
  which is not built in this directory.
Call Stack (most recent call first):
  ExternalProjects/Plugins/UCSBUtilities/CMakeLists.txt:242 (CreatePybind11Module)

In CMake 3.12 rc2 and earlier I don't get the error message. I was trying to keep up with the RCs but just got back from travel to test the release. We were counting on that new feature for a few aspects of our project. Was the feature pulled due to bugs?

--
Michael Jackson | Owner, President
      BlueQuartz Software
[e] [hidden email]
[w] www.bluequartz.net <http://www.bluequartz.net>


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: CMake 3.12 rc2 to rc3 Regression

Michael Jackson
Searching the mailing list archives for the RC3 announcement I scrolled to the bottom and found:

Brad King (2):
      Revert "target_link_libraries: Allow use with targets in other
directories"
      CMake 3.12.0-rc3

Just curious what caused the issue to revert the change?

--
Michael Jackson | Owner, President
      BlueQuartz Software
[e] [hidden email]
[w] www.bluequartz.net <http://www.bluequartz.net>

On 7/18/18, 8:48 AM, "Michael Jackson" <[hidden email]> wrote:

    There was a regression between 3.12-rc2 and 3.12-rc3 where we can no longer add files to a target unless it was built in the directory that is currently being cmaked? Hard to explain, I'll let my error message help out:
   
    In CMake 3.12-rc3 and the 3.12 Official Release I get the following:
   
    -- TransformationPhase [ENABLED] 3 Filters
    -- Plugin: Defining UCSBUtilities_SOURCE_DIR to /Users/mjackson/DREAM3D-Dev/DREAM3D/ExternalProjects/Plugins/UCSBUtilities
    CMake Error at ExternalProjects/SIMPL/Wrapping/Python/Pybind11/cmake/WrappingFunctions.cmake:144 (target_link_libraries):
      Attempt to add link library "UCSBUtilitiesServer" to target "dream3d_py"
      which is not built in this directory.
    Call Stack (most recent call first):
      ExternalProjects/Plugins/UCSBUtilities/CMakeLists.txt:242 (CreatePybind11Module)
   
    In CMake 3.12 rc2 and earlier I don't get the error message. I was trying to keep up with the RCs but just got back from travel to test the release. We were counting on that new feature for a few aspects of our project. Was the feature pulled due to bugs?
   
    --
    Michael Jackson | Owner, President
          BlueQuartz Software
    [e] [hidden email]
    [w] www.bluequartz.net <http://www.bluequartz.net>
   
   
   


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: CMake 3.12 rc2 to rc3 Regression

Craig Scott-3


On Wed, Jul 18, 2018 at 11:04 PM, Michael Jackson <[hidden email]> wrote:
Searching the mailing list archives for the RC3 announcement I scrolled to the bottom and found:

Brad King (2):
      Revert "target_link_libraries: Allow use with targets in other
directories"
      CMake 3.12.0-rc3

Just curious what caused the issue to revert the change?


The original problem report was on the dev mailing list:



The longer history of how the feature evolved and was then reverted can be found here:



--
Craig Scott
Melbourne, Australia


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: CMake 3.12 rc2 to rc3 Regression

Michael Jackson

Thank you for the links.

 

After reading through all the various discussions is there a time line of when the feature will be added back to CMake? Is it a matter of having somebody to work the problem? Is the problem solvable?

--

Michael Jackson | Owner, President

      BlueQuartz Software

[e] [hidden email]

[w] www.bluequartz.net

 

From: Craig Scott <[hidden email]>
Date: Wednesday, July 18, 2018 at 9:40 AM
To: Michael Jackson <[hidden email]>
Cc: CMake <[hidden email]>
Subject: Re: [CMake] CMake 3.12 rc2 to rc3 Regression

 

 

 

On Wed, Jul 18, 2018 at 11:04 PM, Michael Jackson <[hidden email]> wrote:

Searching the mailing list archives for the RC3 announcement I scrolled to the bottom and found:

Brad King (2):
      Revert "target_link_libraries: Allow use with targets in other
directories"
      CMake 3.12.0-rc3

Just curious what caused the issue to revert the change?

 

 

The original problem report was on the dev mailing list:

 

 

 

The longer history of how the feature evolved and was then reverted can be found here:

 

 

 

--

Craig Scott

Melbourne, Australia

 


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake
Reply | Threaded
Open this post in threaded view
|

Re: CMake 3.12 rc2 to rc3 Regression

Robert Maynard
The original author of the feature is looking at how to solve this
problem. The author has a post on the developer boards on some of the
changes needed to get everything to work:
https://cmake.org/pipermail/cmake-developers/2018-July/030760.html
On Thu, Jul 19, 2018 at 8:04 AM Michael Jackson
<[hidden email]> wrote:

>
> Thank you for the links.
>
>
>
> After reading through all the various discussions is there a time line of when the feature will be added back to CMake? Is it a matter of having somebody to work the problem? Is the problem solvable?
>
> --
>
> Michael Jackson | Owner, President
>
>       BlueQuartz Software
>
> [e] [hidden email]
>
> [w] www.bluequartz.net
>
>
>
> From: Craig Scott <[hidden email]>
> Date: Wednesday, July 18, 2018 at 9:40 AM
> To: Michael Jackson <[hidden email]>
> Cc: CMake <[hidden email]>
> Subject: Re: [CMake] CMake 3.12 rc2 to rc3 Regression
>
>
>
>
>
>
>
> On Wed, Jul 18, 2018 at 11:04 PM, Michael Jackson <[hidden email]> wrote:
>
> Searching the mailing list archives for the RC3 announcement I scrolled to the bottom and found:
>
> Brad King (2):
>       Revert "target_link_libraries: Allow use with targets in other
> directories"
>       CMake 3.12.0-rc3
>
> Just curious what caused the issue to revert the change?
>
>
>
>
>
> The original problem report was on the dev mailing list:
>
>
>
> https://cmake.org/pipermail/cmake-developers/2018-June/030740.html
>
>
>
>
>
> The longer history of how the feature evolved and was then reverted can be found here:
>
>
>
> https://gitlab.kitware.com/cmake/cmake/issues/17943
>
>
>
>
>
> --
>
> Craig Scott
>
> Melbourne, Australia
>
> https://crascit.com
>
>
>
> New book released: Professional CMake: A Practical Guide
>
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> https://cmake.org/mailman/listinfo/cmake
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake